ci(codecov): pin the coverage bar at 80% - #17
Merged
Merged
Conversation
Codecov's default target is "auto", meaning the project's own current coverage, so a commit went red unless its diff was covered at least as well as the whole tree already is. 0.6.6 failed exactly that way — "88.07% of diff hit (target 91.13%)" — while being perfectly well tested. An auto target also ratchets: every commit that raises coverage raises the bar for the next one, until any ordinary change is red. Pin it instead. 80% is the bar a commit has to clear, for the diff and for the project; the tree currently sits at 91.2%, so this is headroom rather than a loosened gate. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes 80% the coverage bar a commit has to clear, for the diff and for the project.
Why
Codecov's default target is
auto— the project's own current coverage. So a commit is red unless its diff is covered at least as well as the whole tree already is. PR #16 (release 0.6.6) failed exactly that way:Nothing was wrong with that patch. An
autotarget also ratchets: every commit that nudges coverage up raises the bar for the next one, until ordinary changes go red for no reason anyone can act on.What changed
A
codecov.ymlpinning both statuses to a fixed 80%:The tree is at 91.2%, so this is headroom, not a loosened gate — it stops the bar from chasing the tree.
Validation
codecov.ymlaccepted byhttps://codecov.io/validate("Valid!", target parsed as80.0)..github/workflows/build-and-publish.ymlgreen before push: deps lock, unused lock,hex.audit, format, property deps, compile ×2 (dev + test), dialyzer,credo --all, sobelow, and the test suite under the 60s cap (1755 passed, 91.2%).🤖 Generated with Claude Code